chore: convert @packages/icons to a compiled package and convert tests to vitest
#32649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtofStryker
changed the title
vitest
AtofStryker
force-pushed
the
chore/icons_vitest
branch
from
84f6420 to
27aa98a
Compare
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
chore/icons_vitest
|
| Run status |
|
| Run duration | 10m 53s |
| Commit |
|
| Committer | Bill Glesias |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
3
|
Skipped
|
0
|
Passing
|
857
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
45.7%
|
|
|---|---|
|
Untested elements
|
137
|
|
Tested elements
|
117
|
Accessibility
97.36%
|
|
|---|---|
|
Failed rules
|
3 critical
7 serious
2 moderate
1 minor
|
|
Failed elements
|
77
|
AtofStryker
changed the title
vitest@packages/icons to a compiled package and convert tests to vitest
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
AtofStryker
force-pushed
the
chore/icons_vitest
branch
from
03d443e to
3cf811e
Compare
jennifer-shehane
approved these changes
Oct 7, 2025
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Converts
@packages/iconsto use vitest and removes the ts-node entrypoint making ESM possible. The tests before weren't actually being run in CI. This adds the icons package to the test script so the tests are now executedSteps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?Note
Compiles
@packages/iconswith CJS/ESM entrypoints, migrates tests to Vitest, and adds the package to the root test run while updating related configs/docs.index.js(CJS) andindex.mjs(ESM); introducetsconfig.cjs.json/tsconfig.esm.jsonand sharedtsconfig.base.json; updatepackage.jsonscripts (build,build-assets,build:cjs,build:esm) and fields (module,types); usetsxfor build scripts; adjust dist path inindex.ts.vitest.config.ts, newtest/icons.spec.ts), remove oldtest/icons_spec.ts; switchtest-unittovitest run; add ignore rules for built artifacts.@packages/iconsin top-leveltestscript.guides/esm-migration.mdto markpackages/iconsas completed and tidyhttps-proxyentries.Written by Cursor Bugbot for commit 549af08. This will update automatically on new commits. Configure here.